Skip to content

Det match updates#1581

Merged
mmccrackan merged 8 commits intomasterfrom
260317_det_match
Apr 23, 2026
Merged

Det match updates#1581
mmccrackan merged 8 commits intomasterfrom
260317_det_match

Conversation

@mmccrackan
Copy link
Copy Markdown
Contributor

@mmccrackan mmccrackan commented Mar 17, 2026

Replaces #1515 which was similar. This does the following:

  • Adds a parameter called allow_unassigned_to_assigned which will either allow or prevent matches from bg=-1 in the design or pointing data to bg != -1 in the pointing or tuneset data. We want to prevent such matches when matching from design to pointing, since the detector types with bg=-1 should always have that value. When matching between pointing and tunesets, we allow bg = -1 to other bg values since some detectors may be assigned bg = -1 in det_cal due to the conditions of when the pointing tune was taken but may be recovered in later tunesets (this likely won't happen since it would ideally match the pointing to a bg != -1 detector and copy the bg from the design).
  • Like Det match updates #1515, forces det_types of UNRT, SQID, and BARE to always be bg = -1.
  • Prevents mismatch between assigned bgs (i.e matching bg=4 to bg=6).
  • Makes det_row, det_col, and det_rhombus optional for LF.
  • Adds det_match_solutions code to coords.
  • Adds start_time and stop_time to update_det_match to simplify epoch handling for detsets. Future update will add epochs to the databases.

Remainder of LF matching updates will be in a separate PR after testing and confirming it works on better pointing data (also needs #1603).

@mmccrackan mmccrackan mentioned this pull request Apr 17, 2026
@mmccrackan mmccrackan marked this pull request as ready for review April 20, 2026 21:00
@mmccrackan mmccrackan requested a review from mhasself April 20, 2026 21:03
Copy link
Copy Markdown
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- mostly documentation / tidying requests, but I understand if you need to press forward. Great to have this side of things covered in sotodlib now.

Comment thread sotodlib/coords/det_match.py
Comment thread sotodlib/coords/det_match_solutions.py
Comment thread sotodlib/coords/det_match_solutions.py Outdated
Comment thread sotodlib/coords/det_match_solutions.py
@mmccrackan
Copy link
Copy Markdown
Contributor Author

Thanks -- mostly documentation / tidying requests, but I understand if you need to press forward. Great to have this side of things covered in sotodlib now.

Okay, fixed imports, updated the docstrings and documentation to add a description of the solutions code and what is meant by solutions and pointing, and added and tested the solutions script to update_det_match and the CLI interface.

@mmccrackan mmccrackan merged commit d63b989 into master Apr 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants